chore(attestation): remove collector#1949
chore(attestation): remove collector#1949JayT106 wants to merge 6 commits intorandy/da-integration-testfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
thomas-nguy
left a comment
There was a problem hiding this comment.
cleanup looks good but can you tell me why do we need a rpcClient?
c582bb5 to
d82a3d5
Compare
It's a cometbft rpc client to let cosmos module to access the history block data since we don't store the block or the block metadata in app side. BTW, found we can use local client to remove HTTP overhead and network latency. |
Remove collector based on the discussion in here #1948 (comment)
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)